Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding changelog update in API generator #669

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Feb 7, 2024

Description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17a8471) 72.14% compared to head (56577ba) 72.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          89       89           
  Lines        7945     7945           
=======================================
  Hits         5732     5732           
  Misses       2213     2213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. I think it should hard fail if it can't do the update. Makes the code simpler and more predictable.

utils/generate_api.py Outdated Show resolved Hide resolved
utils/generate_api.py Outdated Show resolved Hide resolved
utils/generate_api.py Show resolved Hide resolved
utils/generate_api.py Outdated Show resolved Hide resolved
@saimedhi
Copy link
Collaborator Author

saimedhi commented Feb 7, 2024

@dblock, made the requested changes. Sample PR generated: https://github.com/saimedhi/opensearch-py/pull/35/files

@dblock dblock merged commit b9d9bae into opensearch-project:main Feb 7, 2024
53 of 55 checks passed
AbitraryYu pushed a commit to AbitraryYu/opensearch-py that referenced this pull request Apr 22, 2024
* Update changelog with api generator

Signed-off-by: saimedhi <[email protected]>

* Update changelog with api generator

Signed-off-by: saimedhi <[email protected]>

---------

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: AbitraryYu <[email protected]>
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024
* Update changelog with api generator

Signed-off-by: saimedhi <[email protected]>

* Update changelog with api generator

Signed-off-by: saimedhi <[email protected]>

---------

Signed-off-by: saimedhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants