-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding changelog update in API generator #669
Conversation
Signed-off-by: saimedhi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 89 89
Lines 7945 7945
=======================================
Hits 5732 5732
Misses 2213 2213 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. I think it should hard fail if it can't do the update. Makes the code simpler and more predictable.
Signed-off-by: saimedhi <[email protected]>
@dblock, made the requested changes. Sample PR generated: https://github.com/saimedhi/opensearch-py/pull/35/files |
* Update changelog with api generator Signed-off-by: saimedhi <[email protected]> * Update changelog with api generator Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]> Signed-off-by: AbitraryYu <[email protected]>
* Update changelog with api generator Signed-off-by: saimedhi <[email protected]> * Update changelog with api generator Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]>
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.